-
Notifications
You must be signed in to change notification settings - Fork 90
Update API to better match Promise spec and add the 'status' prop (closes #35) #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 98.4% 99.61% +1.21%
==========================================
Files 4 5 +1
Lines 502 525 +23
Branches 101 112 +11
==========================================
+ Hits 494 523 +29
+ Misses 4 2 -2
+ Partials 4 0 -4
Continue to review full report at Codecov.
|
|
This branch is available as a pre-release on npm: or: |
|
@ghengeveld Hello, before you create release 6.x, I wondered if you have considered simplifying some of the properties? For example, I think it would be nice to just have a single Maybe do something similar for |
|
Thanks for the suggestion. I've considered this when I introduced |
|
@all-contributors please add @dhurlburtusa for ideas |
|
I've put up a pull request to add @dhurlburtusa! 🎉 |
Async.Pendingwas renamed toAsync.Initialstatusprop, which can be one ofinitial,pending,fulfilledorrejectedisInitial,isPending,isFulfilled(with aliasisResolved),isRejectedandisSettledboolean props.isLoadingis now an alias forisPending.The
pendingandfulfilledstatuses were chosen overloadingandresolvedbecause they better match the terminology in the Promise specification. ThePendinghelper component was renamed toInitialaccordingly, causing a breaking change.