Fix resolved only displaying after rejected defer when persisted #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 91 92 +1
Branches 34 35 +1
=====================================
+ Hits 91 92 +1
Continue to review full report at Codecov.
|
ghengeveld
approved these changes
Oct 4, 2018
|
Released in 3.7.1 Thanks a lot for contributing! 🎉 |
|
Be aware I also released 3.7.2 which fixes a related bug. |
|
Sounds great, thanks for the updates! 😁 |
|
@all-contributors please add @byCedric for code |
|
I've put up a pull request to add @byCedric! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
@norama I'm so sorry if I stole your thunder! I had to wait for one of our Macs to upgrade, and I recently discovered this library. So I thought, why not spend it usefully 😄
Hope this helps!