Skip to content

Conversation

@byCedric
Copy link
Contributor

@byCedric byCedric commented Oct 4, 2018

Fixes #4

@norama I'm so sorry if I stole your thunder! I had to wait for one of our Macs to upgrade, and I recently discovered this library. So I thought, why not spend it usefully 😄

Hope this helps!

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          91     92    +1     
  Branches       34     35    +1     
=====================================
+ Hits           91     92    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91ffe9...6ebbd6a. Read the comment docs.

Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that's awesome. Thanks! Looking good, with tests and all 👍

@ghengeveld ghengeveld merged commit e8aabe4 into async-library:master Oct 4, 2018
@ghengeveld
Copy link
Member

Released in 3.7.1

Thanks a lot for contributing! 🎉

@byCedric byCedric deleted the fix/persist-result-after-rejection branch October 4, 2018 20:17
@ghengeveld
Copy link
Member

Be aware I also released 3.7.2 which fixes a related bug.

@byCedric
Copy link
Contributor Author

byCedric commented Oct 4, 2018

Sounds great, thanks for the updates! 😁

@ghengeveld
Copy link
Member

@all-contributors please add @byCedric for code

@allcontributors
Copy link
Contributor

@ghengeveld

I've put up a pull request to add @byCedric! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants