Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BufWriter #83

Closed
LeshaInc opened this issue Aug 19, 2019 · 3 comments · Fixed by #92
Closed

Add BufWriter #83

LeshaInc opened this issue Aug 19, 2019 · 3 comments · Fixed by #92
Labels
api design Open design questions feedback wanted Needs feedback from users good first issue Good for newcomers mentored Issues where we provide mentoring

Comments

@LeshaInc
Copy link

There is already a BufReader, so people would expect to have a BufWriter too. A lazy implementation is to simply wrap BufWriter from futures-0.3.
@ghost ghost added api design Open design questions good first issue Good for newcomers feedback wanted Needs feedback from users mentored Issues where we provide mentoring labels Aug 19, 2019
@Drevoed
Copy link
Contributor

Drevoed commented Aug 20, 2019

I am currently trying to implement this and encountered some issues, if I make a pull request will someone be able to guide me through?

@skade
Copy link
Collaborator

skade commented Aug 20, 2019 •
edited
Loading

Hi @Drevoed, yes, we're happy to mentor there. It's recommendable to mark the PR as draft. Please be aware that we're currently en route to RustConf, so we might take some time.

Also feel free to jump on the Discord.

This was referenced Aug 20, 2019
Closed
Merged
@yoshuawuyts
Copy link
Contributor

Ref #131 also (tracking issue for async_std::io)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api design Open design questions feedback wanted Needs feedback from users good first issue Good for newcomers mentored Issues where we provide mentoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

draft Buf writer Drevoed/async-std
draft Add BufWriter Drevoed/async-std
4 participants
@skade @yoshuawuyts @LeshaInc @Drevoed