New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

figure out how to work with temporal streams too #14

Open

yoshuawuyts opened this issue Jan 8, 2022 · 3 comments

Collaborator

yoshuawuyts commented Jan 8, 2022 •

edited

Loading

Collaborator Author

yoshuawuyts commented Jan 8, 2022

We need to distinguish between a deadline and a boundary. Deadlines are hit exactly once. Boundaries can be hit multiple times.

Collaborator Author

yoshuawuyts commented Jan 8, 2022 •

edited

Loading

Maybe we should rename {AsyncIter, Future}::until with:

AsyncIter::timeout takes impl Boundary
AsyncIter::timeout_at takes impl Deadline
Future:timeout takes impl Boundary
Future::timeout_at takes impl Deadline

note: timeout_at takes StopToken, Instant, and possibly SystemTime.

Collaborator Author

yoshuawuyts commented Jan 8, 2022

Prior art for this naming:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment