Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SASL mechanisms to the schema #53

Merged
merged 3 commits into from
May 28, 2021
Merged

feat: add SASL mechanisms to the schema #53

merged 3 commits into from
May 28, 2021

Conversation

dalelane
Copy link
Collaborator

Split into separate commits to make it easier to review the addition I've
made to the schema.

The first commit is just a copy of the 2.0.0.json file
The second commit is the changes for SASL security schemes
The third commit updates the schema version

Contributes to: asyncapi/spec#466

Signed-off-by: Dale Lane dale.lane@uk.ibm.com

Copy of 2.0.0.json

Contributes to: asyncapi/spec#466

Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
Contributes to: asyncapi/spec#466

Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
Contributes to: asyncapi/spec#466

Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@dalelane dalelane changed the title feat: Add SASL mechanisms to the schema feat: add SASL mechanisms to the schema Apr 22, 2021
@derberg
Copy link
Member

derberg commented Apr 23, 2021

@dalelane can you please remove the changes done to package files. We have automated releases and version bumps here. feat: means that after merge it will be automatically released with new minor version and bot will make a commit that updates version in package.json

@dalelane
Copy link
Collaborator Author

@dalelane We have automated releases and version bumps here. feat: means that after merge it will be automatically released with new minor version and bot will make a commit that updates version in package.json

That's really cool! Not seen that done before

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. Thanks for separating things into different commits for a better review. Really helped :)

@fmvilas fmvilas changed the base branch from master to 2021-06-release April 23, 2021 20:12
@fmvilas fmvilas merged commit 4557cc9 into asyncapi:2021-06-release May 28, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.8.0-2021-06-release.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants