-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SASL mechanisms to the schema #53
feat: add SASL mechanisms to the schema #53
Conversation
Copy of 2.0.0.json Contributes to: asyncapi/spec#466 Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
Contributes to: asyncapi/spec#466 Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
Contributes to: asyncapi/spec#466 Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@dalelane can you please remove the changes done to package files. We have automated releases and version bumps here. |
That's really cool! Not seen that done before |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me. Thanks for separating things into different commits for a better review. Really helped :)
🎉 This PR is included in version 2.8.0-2021-06-release.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Split into separate commits to make it easier to review the addition I've
made to the schema.
The first commit is just a copy of the 2.0.0.json file
The second commit is the changes for SASL security schemes
The third commit updates the schema version
Contributes to: asyncapi/spec#466
Signed-off-by: Dale Lane dale.lane@uk.ibm.com