fix: incorrect rendering of security schemas #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
RobinTail
changed the title
RobinTail
changed the title
RobinTail
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
|
@RobinTail due to some refactor from #996 you need to solve merge conflicts. Sorry about that. |
|
|
@derberg && @magicmatatjahu , |
derberg
approved these changes
Apr 25, 2024
|
Thanks @RobinTail /rtm |
|
🎉 This PR is included in version 1.4.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 25, 2024
This was referenced Aug 1, 2024
This was referenced Aug 12, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993
Incorrect rendering of security schemas in AsyncAPI 3.0, by reference and inline.
See asyncapi/studio#1066
Changes proposed in this pull request:
securityproperty supplied toSecuritycomponent seems to be enough to fix all issues:Perhaps I didn't understand something, but without all those complications it seem to work well on all cases and the tests are passing. Anyway, consider it a proposal, feel free to make or request changes.
Related issue(s)
asyncapi/studio#1066