Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding all generator codeowners here #182

Open
jonaslagoni opened this issue Aug 11, 2023 · 3 comments
Open

Adding all generator codeowners here #182

jonaslagoni opened this issue Aug 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@jonaslagoni
Copy link
Member

Reason/Context

It doesn't make sense to me that the generator and this library don't have the same codeowners, as they are directly linked.

So I am suggesting that we add @fmvilas @derberg as codeowners here.

Any thoughts? cc @magicmatatjahu
@jonaslagoni jonaslagoni added the enhancement New feature or request label Aug 11, 2023
@derberg
Copy link
Member

derberg commented Sep 4, 2023

wait, what? why me?

@jonaslagoni
Copy link
Member Author

Because it does not make sense that this library has different codeowners then the ones in the generator 😄

@derberg
Copy link
Member

derberg commented Sep 4, 2023

what if we rewrite to JS and merge with Generator project? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derberg @jonaslagoni