Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator watcher enters infinite loop with React template #465

Closed
jonaslagoni opened this issue Dec 16, 2020 · 2 comments · Fixed by #471
Closed

Generator watcher enters infinite loop with React template #465

jonaslagoni opened this issue Dec 16, 2020 · 2 comments · Fixed by #471
Labels
bug Something isn't working released

Comments

@jonaslagoni
Copy link
Member

jonaslagoni commented Dec 16, 2020

Describe the bug

Currently the transpiled files when using a React template are not ignored. This causes the generator watcher to go into an infinite loop since the very changes it detects are from its own process while rendering the files. The transpiler it uses does not care of the previous state of the files and always overwrites them.

How to Reproduce

I used the markdown template where I used the command npm run dev.

Discovered while reviewing asyncapi/markdown-template#43

Expected behavior

I would expect the watcher to ignore the transpiled files directory when its a React template.

@jonaslagoni jonaslagoni added the bug Something isn't working label Dec 16, 2020
@jonaslagoni
Copy link
Member Author

The underlying watcher library supports path ignoring which can be used to solve this issue.

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants