-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding interpreter options ignoreAddtionalProperties and ignoreAddtionalItems #1094
feat: adding interpreter options ignoreAddtionalProperties and ignoreAddtionalItems #1094
Conversation
@200Puls feel free to check this feature. I hope it will land soon in a stable release. For now we decide to start small and allow changing the behavior of |
@jonaslagoni please take a look when you have a chance. Thank you! 🙇 |
Pull Request Test Coverage Report for Build 4006812059
💛 - Coveralls |
Hi @artur-ciocanu Thanks for the notification. This matches my use case too. I want to disable both of these. We have started using the build from the next branch for some other features. Will this be merged into both? |
The |
Ah cool I totally missed that. |
@jonaslagoni thanks for merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, otherwise it looks good 👍
6e8c186
to
f411be9
Compare
@jonaslagoni I have addressed your comments, let me know if it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some doc changes 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/rtm |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@200Puls it is finally out, please check it out! |
Hi @artur-ciocanu works for me. Thanks for your effort! |
Description
This is an enhancement that would allow anyone to override default interpreter behavior for
additionalProperties
, andadditionalItems
.A typical example using these interpreter options would look like this: