Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] File Reading Method in the Example script is not appropriate #251

Closed
2 tasks done
KhudaDad414 opened this issue Apr 17, 2024 · 4 comments · Fixed by #255
Closed
2 tasks done

[BUG] File Reading Method in the Example script is not appropriate #251

KhudaDad414 opened this issue Apr 17, 2024 · 4 comments · Fixed by #255
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug Something isn't working good first issue Good for newcomers released

Comments

@KhudaDad414
Copy link
Member

Describe the bug.

The example script uses relative paths (./examples/input.yaml and ./examples/output.yaml) to handle file reading and writing operations, it will fail if executed from different directories.

Expected behavior

The script should manage file paths using the __dirname variable to ensure consistent behaviour irrespective of the current execution directory. This will ensure correct file referencing at all times.

Screenshots

How to Reproduce

  1. clone the project.
  2. compile it with npm run dev
  3. run cd examples then node index.js

🥦 Browser

Other

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it

@KhudaDad414 KhudaDad414 added the bug Something isn't working label Apr 17, 2024
@KhudaDad414
Copy link
Member Author

/gfi js

@asyncapi-bot asyncapi-bot added area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Apr 17, 2024
@omidNM24
Copy link
Contributor

Hi @KhudaDad414, can I work on this issue?

@KhudaDad414
Copy link
Member Author

Sure. 👍

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants