Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for messageId #414

Closed
smoya opened this issue Nov 29, 2021 · 4 comments · Fixed by #510
Closed

Add support for messageId #414

smoya opened this issue Nov 29, 2021 · 4 comments · Fixed by #510
Labels

Comments

@smoya
Copy link
Member

smoya commented Nov 29, 2021

Reason/Context

This is a follow-up issue coming from asyncapi/spec#458.

Description

As per the RFC, we need to add support for messageId at message level. This issue helps tracking progress on it.
Note that it should not break any behavior in place, and the parser should be smart enough for detecting if you are using the new messageId field or rather relying on the name (no breaking change should be introduced, so it should be compatible with previous spec version)

Note: since the feature is not considered a breaking change, we could include it either on 2.3.0 or 3.0.0, depending on how "fast" we move on.

cc @WaleedAshraf

@smoya smoya added the enhancement New feature or request label Nov 29, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 30, 2022
@smoya
Copy link
Member Author

smoya commented Mar 30, 2022

@magicmatatjahu would you mind removing the stale label? Thks!

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.15.0-2022-04-release.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@magicmatatjahu
Copy link
Member

Supported by #510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants