Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-trigger message payload validation #351

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Mar 13, 2023

Description
This PR re-triggers the release workflow as it failed the last time #334

@smoya
Copy link
Member

smoya commented Mar 13, 2023

Adding more context: The action keeps failing since the merged commit didn't have the fix for increasing the timeout on the test (the actual error). This PR is up-to-date and contains such a change.

@smoya
Copy link
Member

smoya commented Mar 13, 2023

@jonaslagoni can you just do git commit --alow-empty instead of adding that empty line?

@derberg
Copy link
Member

derberg commented Mar 13, 2023

I don't think we need it, I'm rerunning the initial release. MacOS just went through, waiting for Windows

@smoya
Copy link
Member

smoya commented Mar 13, 2023

I don't think we need it, I'm rerunning the initial release. MacOS just went through, waiting for Windows

LOL! The previous re-run I made was also failing. Now it seems it doesn't.

good-luck-salute-gif

@derberg
Copy link
Member

derberg commented Mar 13, 2023

yeah, call me re-run ninja

@derberg
Copy link
Member

derberg commented Mar 13, 2023

ok, it worked, but no release, and no changes were detected 🤔

https://github.com/asyncapi/spec-json-schemas/actions/runs/4404537995/jobs/7715620229

@derberg
Copy link
Member

derberg commented Mar 13, 2023

oh yeah, after all you need to merge this as release was not triggered as in the meantime you merged PR with timeout increase 🤷🏼

@jonaslagoni
Copy link
Member Author

Yea 😄

This reverts commit 2074418.
@jonaslagoni
Copy link
Member Author

@smoya done 🙂

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 9b1b4c3 into asyncapi:next-major-spec Mar 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants