Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt Kafka bindings to v3 - take 2 #453

Merged

Conversation

lbroudoux
Copy link
Collaborator

@lbroudoux lbroudoux commented Nov 24, 2023

Description

  • This is a replacement to feat: adapt Kafka bindings to v3 #446 to better align on other bindings that move to v3
  • This let only 0.4.0 and 0.3.0 being the possible versions of Kafka bindings to use with v3 specs
  • See the discussion and decision summarized here

Related issue(s)

Relates to asyncapi/bindings#182

Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com>
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member

fmvilas commented Nov 28, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 81b53c4 into asyncapi:next-major-spec Nov 28, 2023
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants