Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding optional version to the message object #558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IsmaelMartinez
Copy link

Description

Add optional version to the message object
Part of the asyncapi/spec#1068 RFC 0

Related issue(s)

asyncapi/spec#1068
asyncapi/spec#1069

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not approving because, although I'm a maintainer of the repo, I've been completely disconnected from the work it's happening here and I'm not sure these are the files we should be touching 😅 Therefore, leaving it to others who are more engaged.

schemas/3.0.0-without-$id.json Outdated Show resolved Hide resolved
schemas/3.0.0.json Outdated Show resolved Hide resolved
@Pakisan
Copy link
Member

Pakisan commented Oct 1, 2024

@IsmaelMartinez looks good

Waiting for test to test new property

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsmaelMartinez make sure to change the definitions not the schemas as they are automatically generated on each release 🙂

You can find the message object here: https://github.com/asyncapi/spec-json-schemas/blob/master/definitions/3.0.0/messageObject.json

@IsmaelMartinez
Copy link
Author

Thanks for the review. I will see if I can make those changes later on. 1st time in here so apologies for silly mistakes ;)

Copy link

sonarcloud bot commented Oct 1, 2024

@IsmaelMartinez
Copy link
Author

Hi all, I just made the changes. We got an conversation open on the RFC but hopefully we can reach a consensus in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants