Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added servers field to channel object #97

Merged
merged 10 commits into from
Sep 21, 2021

Conversation

GeraldLoeffler
Copy link
Collaborator

Description

Added servers as a list of strings (server names) under the channel object

Related PR(s)

asyncapi/spec#531
asyncapi/parser-js#364

Related issue(s)

asyncapi/spec#244
asyncapi/spec#255
asyncapi/spec#475

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@GeraldLoeffler
Copy link
Collaborator Author

@derberg : this is the JSON schema change for the spec and JS parser change i've recently submitted

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However I would wait others to review!

@magicmatatjahu
Copy link
Member

@derberg Do you wanna add something?

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@derberg derberg merged commit 225310a into asyncapi:2021-09-release Sep 21, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.9.0-2021-09-release.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.9.0-2021-09-release.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants