Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name and summary properties to message examples #54

Merged
merged 4 commits into from
Jun 23, 2021
Merged

feat: add name and summary properties to message examples #54

merged 4 commits into from
Jun 23, 2021

Conversation

lbroudoux
Copy link
Collaborator

Description

Complete message examples with name and summary attributes in order to:

  • provide better documentation for examples,
  • allow development of tooling leveraging examples (see Microcks.io)

This is implementing the latest proposition we had when discussing the topic. It does not introduce breaking changes and thus can be applied to current 2.0.0.

Related issue(s)

This contributes to asyncapi/spec#329

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

schemas/2.0.0.json Outdated Show resolved Hide resolved
schemas/2.0.0.json Outdated Show resolved Hide resolved
@derberg derberg changed the base branch from master to 2021-06-release June 22, 2021 11:01
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
thanks @magicmatatjahu for helping out!

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@derberg derberg changed the title feat: complete message examples with name and summary feat: add name and summary properties to message examples Jun 23, 2021
@derberg derberg merged commit a8ca723 into asyncapi:2021-06-release Jun 23, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.8.0-2021-06-release.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants