feat: added server variable object as reusable object

[danielkocot]

---

title: "Server Variable Object as reusable object"

---

Related issue(s):
#707

The PR targets to have Server Variable Objects as reusable objects within the Component Object.

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[magicmatatjahu]

For me it looks good 🚀 We have first feature to 2.4.0!

I'm not a maintainer of that repo, so I cannot accept it 😅 cc @derberg @fmvilas
You should be also interest @smoya @jonaslagoni

[fmvilas]

LGTM so far 👍

The only thing I'm missing now is the PRs on the https://github.com/asyncapi/spec-json-schemas and https://github.com/asyncapi/parser-js/ repos.

[danielkocot]

asyncapi/spec-json-schemas#174

[danielkocot]

Can anybody help me with the PR for the https://github.com/asyncapi/parser-js/ repo?

[magicmatatjahu]

@danielkocot Sure! You should write needed method for new field in this class https://github.com/asyncapi/parser-js/blob/master/lib/models/components.js like serverVariables, hasServerVariables, serverVariables(name) and then write tests in the https://github.com/asyncapi/parser-js/blob/master/test/models/components_test.js file for new methods. If you will have problems please ping me :)

[danielkocot]

Last missing PR: asyncapi/parser-js#476

[derberg]

@danielkocot please have a look at examples. You propose serverVariables to be under components, but in examples, it is on the root.

[magicmatatjahu]

@derberg Check again :) They are inside components in examples.

[derberg]

ah 😅 servers were also under components 😄 sorry folks 🍺

[smoya]

@danielkocot we have now release branches for 2.4.0. Would you mind changing the base branch to 2022-04-release ? Thanks!

EDIT: NVM! better to wait first #736 to be merged. Then I will ping you again. Thanks.

[smoya]

@danielkocot #736 has been merged. Would you mind changing the base branch to 2022-04-release ? Thanks!

[dalelane]

LGTM 👍

[smoya]

@derberg can you approve the workflows so they can run? Thanks

[smoya]

@fmvilas as per your comment, it looks OK to you. Would you mind checking again now that all PR's have been created?

[magicmatatjahu]

LGTM :)

[smoya]

@danielkocot there is only one little thing to fix here and we will be most probably ready to merge it soon 🚀

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[smoya]

We still need the approval of @derberg and @fmvilas here.

[smoya]

@derberg @fmvilas @dalelane if you agree, please add the RFC-3 label and proceed with merging. Thanks!

[derberg]

done, main issue has it already too

[smoya]

All PR's have been merged. Proceeding with this PR.

[smoya]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 2.4.0-2022-04-release.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀