Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: simplify parameter object #935

Merged

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented May 11, 2023

Following our conversations in the Spec 3.0 meetings, here's the simplification of the Parameter Object.

Fixes #583

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmvilas
Copy link
Member Author

fmvilas commented May 29, 2023

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @fmvilas! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@fmvilas
Copy link
Member Author

fmvilas commented May 29, 2023

/au

@fmvilas
Copy link
Member Author

fmvilas commented May 29, 2023

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @fmvilas! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmvilas
Copy link
Member Author

fmvilas commented May 29, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 1987e69 into asyncapi:next-major-spec May 29, 2023
@fmvilas fmvilas deleted the simplify-parameters-schema branch May 29, 2023 06:52
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jonaslagoni
Copy link
Member

@fmvilas is it true this require no changes to the parser nor spec-json-schema?

@jonaslagoni jonaslagoni mentioned this pull request Jun 13, 2023
@fmvilas
Copy link
Member Author

fmvilas commented Jun 16, 2023

🤔 No, I think it does require changes in these repos. I just didn't do them. Easy change though.

@jonaslagoni
Copy link
Member

Alright, added it to the progress section of #691 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants