-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upgrade GH workflows and fix markdown linting #958
Conversation
ok, new linter workflow works, and fails if error simulated (I made changes in config) https://github.com/asyncapi/spec/actions/runs/5739972585/job/15556776030?pr=958 |
@jonaslagoni how is this affecting 3.0 work? I guess the problem might be with the |
@derberg the problems it highlight, is not really problems when rendered in the website is it? 🤨 |
@jonaslagoni you mean headings and whitespaces? |
Kudos, SonarCloud Quality Gate passed! |
@derberg once this is merged I would assume we can discard any of the |
So a manual merge commit is needed for sure yea |
Can we proceed merging this? cc @derberg @jonaslagoni Is anything else missing? |
@smoya yep, just need your review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
/rtm |
🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixes: #940
additionally:
mlc_config.json
that was no longer needed as we removed links validation for now