Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually setting a JSON Schema URL #207

Closed
smoya opened this issue Dec 8, 2021 · 14 comments
Closed

Allow manually setting a JSON Schema URL #207

smoya opened this issue Dec 8, 2021 · 14 comments
Labels
enhancement New feature or request stale

Comments

@smoya
Copy link
Member

smoya commented Dec 8, 2021

Reason/Context

Current Studio picks up a JSON Schema from https://github.com/asyncapi/spec-json-schemas based on the asyncapi field.
This is valid for most of the users but I wonder if we could allow users to manually enter a URL of a valid JSON Schema (AsyncAPI one) so it can be used for validating.

The reason is that I find it useful for testing changes on the spec that are not yet fully merged.
I know the use case is very limited, but wondering if we could easily do that.

Description

Allow setting an external JSON Schema URL so it can be used for validating the document. It doesn't have to be in the UI, maybe a query parameter such as ?schema=<url> would be enough.

@smoya smoya added the enhancement New feature or request label Dec 8, 2021
@magicmatatjahu
Copy link
Member

Do you wanna validate on different schema by parserJS? Currently parserJS has hardcoded versions of specs and you cannot pass new schema as input to the parser.

@smoya
Copy link
Member Author

smoya commented Dec 8, 2021

Do you wanna validate on different schema by parserJS? Currently parserJS has hardcoded versions of specs and you cannot pass new schema as input to the parser.

I know you load schemas at boot time, but I guess you can also add more schemas to the registry during runtime.

@magicmatatjahu
Copy link
Member

🤔 We can add new schema to the global object from @asyncapi/specs. I will think about it.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Apr 8, 2022
@smoya
Copy link
Member Author

smoya commented Apr 8, 2022

@magicmatatjahu What do you think about this one? I think it is valid? If you do as well, please remove the stale label 🙇

@github-actions github-actions bot removed the stale label Apr 9, 2022
@magicmatatjahu
Copy link
Member

I think it's still relevant :)

@smoya
Copy link
Member Author

smoya commented May 5, 2022

I think it's still relevant :)

In fact, I wanted to use Studio during the prerelease of AsyncAPI 2.4.0 to test such a new version and missed this feature.

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Sep 3, 2022
@smoya
Copy link
Member Author

smoya commented Sep 5, 2022

Still relevant

@derberg
Copy link
Member

derberg commented Oct 6, 2022

this first has to be supported by the parser, no?

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Oct 6, 2022

@derberg More specifically by Spectral. We can always override some rules from official Spectral's AsyncAPI ruleset in our Parser, it's not a problem.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 4, 2023
@smoya
Copy link
Member Author

smoya commented Feb 4, 2023

Still relevant

@github-actions github-actions bot removed the stale label Feb 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 6, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants