-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout improvement #703
Comments
Hey @Amzani Let me know if you require assistance in solving this issue. I can pick it up if the issue is unblocked. I'll go through the issue and clarify any requirements once I get the go-ahead from your end. |
Hi @divyammadhok This work will start after cycle 1 is done: https://shapeit.app/projects/org/asyncapi/16/cycles/e4232524 |
Thanks @Amzani Sounds good! |
Do we want to wait until the next architecture #725 is completed before integrating the components ? Any thoughts ? @Shurtu-gal @fmvilas @KhudaDad414 |
Yeah we wouldn't want to increase the task of migration by adding components before everything is decided. |
@divyammadhok you might be interested to joining this effort: https://asyncapi.slack.com/archives/CQVJXFNQL/p1690810559915289 |
@Amzani Can you share the access to this channel |
@divyammadhok sorry for the silence. There have been summer holidays recently and @Amzani probably missed your message. You can sign in to our Slack here: https://asyncapi.com/slack-invite. After that, you'll be able to see the content of this link. Hope that helps. |
Hey @fmvilas Got through your message now, and I believe that the link is not valid anymore. Can you please ping this to me again? I'll make a note of joining it on time. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Thanks for creating a new pitch 🥳. You can now create or link existing scopes. Option 1
See this example Option 2
See this example |
Hey @Amzani can i give a hand or two in this? |
Hii @Shurtu-gal @Amzani @KhudaDad414 Is there been any plan on how to show the user avatar dynamically? |
We don't need to add the avatar as we don't support users (signin/signup) in studio @utnim2 |
@Amzani many parts of the studio are not completed yet that is there in the figma file Thanks |
Best to coordinate with @Shurtu-gal as he is working on the NextJS migration, I suggest to add this enhancement as part of the new app in |
@utnim2 @Shurtu-gal is adding the Editor to NextJS app in this PR #997 (still under review), this will be useful here. |
i am working on sidebar and the topbar |
Problem
The previous top bar disappears as it was useless (it only had the Studio logo and some links to stuff not related to Studio). Instead, it's now holding the name of the service (AsyncAPI file) we're developing and a few buttons to customize the layout. These are just the buttons that used to be on the sidebar, i.e., toggle Navigation, Docs, Diagnostics, etc.
But probably, the biggest change here is the introduction of this new sidebar on the left. It contains a bunch of buttons and also the avatar of the user. This new sidebar is meant to be the navigation for the whole application, meaning it's not just for the code editor as it was before. The purpose of this sidebar is to navigate to other parts of the application like Services, Governance, Settings, and more.
In general, now the layout is accommodated to start growing the application in a friendly and sane way.
Solution
Link to Figma: https://www.figma.com/proto/bPMB3lkMTOOMuKk0oGLuNm/Studio?type=design&node-id=144-4141&scaling=contain&page-id=0%3A1&starting-point-node-id=2%3A2
Rabbit holes
Scope
Out of bounds
Success criteria
The text was updated successfully, but these errors were encountered: