-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[📑 Docs]: AsyncAPI CLI Documentation #602
Comments
Hey there @imabp, thank you for your OSS submission and interest and contribution! I def want to work with you on this, and even regardless of Let me share where in the Docs this would be great to start adding. 😀
Let me know if that makes sense or what questions/thoughts 💭 you may have. 😄👍🏽👍🏽 |
Thank you for following up on this. @alequetzalli Also, we are adding more features for CLI, so I am just waiting for few PRs to get merged, and then generating the doc out of it. 😄 |
That sounds great @imabp, looking forward to seeing the new CLI features and your upcoming doc PR ✨✨ |
🤩 Wow love the new design for docs. In terms of CLI, I have one small doubt - Workflow/pipeline for new documentationCLI still hasn't reached v1 yet so many new features are added and changed on regular basis, for this we thought of using tools like https://openbase.com/js/oclif/documentation#oclif-readme to generate documentation but it looks something like this asyncapi/cli#123 (comment) which is probably not that intuitive.
|
@Souvikns The workflow will be the same for all docs. It is put in a PR, goes through a review process, and eventually when approved gets merged. We do not have tools for generating docs yet, but even when we do add them, we will be going through a Technical Writing review, we are not going to copy/paste random stuff from READMEs :) |
@Souvikns , as some features have been decided for V1, I will start documenting them. Hope that's fine |
my 5 cents: just let us remember folks, in the case of CLI, we should generate docs from code as much as possible. We already know that sometimes in |
@derberg that sounds good to me, do I need to sync w/ you or someone else about how the coding side of generating them can be done? I think we still need to identify a contributor for that, right? 🤔 💭 Or are you also working on that, @imabp? P.S. @imabp let me know if you need more guidance on getting the CLI Docs PR started, I have more folks tagging me lately in Docs so I want to make sure I don't leave you forgotten 🤣 ❤️ I am also now going to greatly update this issue so that I can provide more guidance and help make this a |
I can help with this @alequetzalli. |
I have some doubts about where should we keep our documentation, should it be in the website repo or the CLI repo.
One more thing, @alequetzalli we had this going on for CLI's documentation generation asyncapi/cli#123 (comment) can you tell me that is this generated document good enough.
|
by principle, technical docs belong to the repo where the code is. So docs are updated in the same PR that code is updated. so we write/generate docs in and yes, we should have decent dev docs for contributors to ease contribution. |
@Souvikns As @derberg explained, we will write/generate the initial README docs in the That said, that PR from repo READMEs to website Docs will undergo a thorough review before it gets approved/merged into the website's main Docs.
This is useful and can/should be added to our website's main Docs, but again, this is not ready to be pushed LIVE to our Docs. This is rough and needs to go through PR review. 😄 @Souvikns let me know if that makes sense ! |
Hey @imabp, that's a great follow-up question! Thank you for noting and remembering that we were making some key changes to the Docs Information Architecture first... The current update is here in my Gist that I just wrote: As you can see, that PR #601 is still in dev/design/writing stage so we are SOOOO close to being able to start adding docs that are generated. I think we are very close to closing that PR, it seems to be mostly done.. and I will keep you in the loop! Essentially, for now start planning for CLI docs to go under: I think that is enough to start creating your tool to generate the docs and migrate them to website repo? I assume you are creating a tool that pushes them into the website repo too, or rather.. generates a PR to the website repo too. That said, that PR from repo READMEs to website Docs will undergo a thorough review before it gets approved/merged into the website's main Docs. Let me know if this makes sense and what you think 💭 😸 |
This works really well 😁. On it @alequetzalli |
Hi @alequetzalli I love to contribute to AsyncAPI to create the AsyncAPI CLI documentation. |
Hello @icode247 , I am actually working on this locally. There are other many issues that needs a care. Please do take a look at them. |
@icode247 Like Abir noted, this issue is already assigned :) |
So I was brainstorming about this. And need some answers to these two questions
✨ Now I need to know inputs from @alequetzalli @magicmatatjahu @Souvikns @derberg, about all this and how you feel about it ? |
(1)Hey, thanks for asking but we do not want CLI under tools. I an placing anything related to console, dev env, and API spec under Reference 😄 Please go ahead as we already planned so that your awesome ✨CLI✨ contribution would go under the new Information Architecture under the Reference section, with the URL being: (2) So I like where you're mind is going but this is the outline I'm going for when you add your docs to the PR:
Good question about the code owners, the way it works for But if you're editing documentation files in other repoes (example: the |
@imabp Hmmm... I am still thinking about using "Get started" because I like that "installation" is to the point. But if you want to try that, then I want you to change it to
Yes, this looks right. But 2 Command Reference, also needs to generate a PR to be reviewed. I run into too many spelling and grammar issues, so we must have that reviewed always before added to the website Docs. |
Yes,
Regarding the following @alequetzalli
Yes though its generated by a bot, you can still review it for the grammatical mistakes before merging the PR 😄 |
@imabp Thanks for clarifying that both ways generate a PR first; that's what I needed to make sure. Sounds great! 👍🏻 |
@alequetzalli I have a question, where should @imabp open the PR, in the CLI repo or the website repo. I personally think it should be in the CLI repo just like spec and then we can sync it using a GitHub action much like spec repo does. We can add you as a code owner in the CLI repo for review purposes.
|
As you see above the structure.
|
|
Finally, its a victory 🤭....for both of us ✨ Awesome, Thanks again @alequetzalli for approving this |
@Souvikns we can continue on the CLI command reference using the tool mentioned in asyncapi/cli#123 And I will be writing the getting started document |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
still valid |
@derberg i wish, if we could assign priorities here...This is of lower priority, as more features are being developed in CLI. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
What Dev Docs changes are you proposing?
About CLI
CLI helps you to work with AsyncAPI files.
The following set of features are available(some are waiting to get merged and planned to be released in V1).
Documentation
We currently do not have any documentation on front-end for the user to know the available set of commands and examples showcasing, their usage. This issue tries to resolve the same.
It will be nice to have a document for CLI at this page
https://www.asyncapi.com/tools/cli
Documentation Structure
This is an example documentation structure showcasing new validate and diff commands.
AsyncAPI Example Specification
Commands Usage
new
validate
diff
Accountability and Notes
I can work on this and probably based on, if we are in, it can be a part of Season Of Docs.
Project Board: https://github.com/orgs/asyncapi/projects/8
Code of Conduct
The text was updated successfully, but these errors were encountered: