Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic import of node_modules #13

Open
macmladen opened this issue Sep 22, 2015 · 5 comments
Open

Automatic import of node_modules #13

macmladen opened this issue Sep 22, 2015 · 5 comments

Comments

@macmladen
Copy link

It would be nice to support node_modules import the way bower is supported as lot of libraries can now be downloaded with npm therefore reducing complexity and eliminating bower if possible.

Like:

var sass = require('node-sass');,
    importOnce = require('node-sass-import-once');

sass.render({
  file: scss_filename,
  importer: importOnce,
  importOnce: {
    index: false,
    css: false,
    bower: false,
    node: false
  }
});
@JohnAlbin
Copy link
Member

+1

I had to install bower just to use node-sass-import-once's auto-import feature.

@macmladen macmladen changed the title Automattic import of node_modules Automatic import of node_modules Oct 29, 2015
@macmladen macmladen changed the title Automatic import of node_modules Automatic import of node_modules Oct 29, 2015
@JohnAlbin
Copy link
Member

I've briefly looked at how to implement this and realize we may be screwed. The new flat directory structure of the new Node.js node_modules folder means that I have a ridiculous amount of folders to search through.

For example, if the only 3 things in my package.json dependencies is: gulp, gulp-sass, node-sass-import-once, I get 228 folders in node_modules. Ooof.

@Snugug
Copy link
Member

Snugug commented Nov 2, 2015

Yah, I'm going to leave node module imports to Eyeglass

On Nov 1, 2015, at 6:01 PM, John Albin Wilkins notifications@github.com wrote:

I've briefly looked at how to implement this and realize we may be screwed. The new flat directory structure of the new Node.js node_modules folder means that I have a ridiculous amount of folders to search through.

For example, if the only 3 things in my package.json dependencies is: gulp, gulp-sass, node-sass-import-once, I get 228 folders in node_modules. Ooof.


Reply to this email directly or view it on GitHub.

@strarsis
Copy link

Well, one valid use case for this, even when eyeglass is used, are npm packages for sass styles
that don't come with the necessary eyeglass metadata or structure yet.

With best regards

@Snugug
Copy link
Member

Snugug commented Feb 21, 2016

Agreed. Will get rolling on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants