-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.4.7 broke compatibility #50
Comments
Hello, Not perfectly sure my problem is related to this incompatibility, but with function getOptions(loaderContext) {
const query = loaderContext.query;
if(typeof query === "string" && query !== "") {
return parseQuery(loaderContext.query);
}
if(!query || typeof query !== "object") {
// Not object-like queries are not supported.
return null;
}
return query;
} However, the nunjucks-loader is giving a string: if (!hasRun){
var query = loaderUtils.getOptions(this.query); and thus, the if (!hasRun){
var query = loaderUtils.getOptions({query: this.query}); then it works as expected. note: I'm using Webpack 1 in my project and my Webpack configuration is like that:
|
|
Hello,
You have recently released version 2.4.7 of nunjucks-loader. However, in that release you have incremented the version of your dependency loader-utils from ^0.2.12 to ^1.0.0. This is a breaking change, so your 2.4.7 release violates the rules of semantic versioning.
In effect, this broke the build of multiple projects we are maintaining, because loader-utils version 1.x no longer compiles under the version of node JS we are using. Please fix your release.
The text was updated successfully, but these errors were encountered: