Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logic for obtaining host value used to submit SNI-compatible cert chain request #463

Open
atc0005 opened this issue Jan 31, 2023 · 0 comments
Assignees
Labels
app/lscert enhancement New feature or request output/extended Long Service Output (aka, "extended" or "detailed") output/logging plugin/check_cert sni
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Jan 31, 2023

Overview

Need to refactor the logic used to obtain the host value used in SNI-compatible cert chain request. At present, the logic is nearly 1:1 between the lscert and check_cert tool. As it happens, I just fixed a bug affecting both separately instead of fixing in one place (as ideally I would have been able to do).

I should review the code and pull out as much as possible as shared logic to dedupe future maintenance efforts.

References

@atc0005 atc0005 added enhancement New feature or request plugin/check_cert output/logging app/lscert sni output/extended Long Service Output (aka, "extended" or "detailed") labels Jan 31, 2023
@atc0005 atc0005 added this to the Future milestone Jan 31, 2023
@atc0005 atc0005 self-assigned this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/lscert enhancement New feature or request output/extended Long Service Output (aka, "extended" or "detailed") output/logging plugin/check_cert sni
Projects
None yet
Development

No branches or pull requests

1 participant