Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "language names" with spaces in-between #155

Closed
Poisonlocket opened this issue Mar 29, 2024 · 9 comments · Fixed by #156
Closed

Ignore "language names" with spaces in-between #155

Poisonlocket opened this issue Mar 29, 2024 · 9 comments · Fixed by #156
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Poisonlocket
Copy link

considering it has a space im not sure how to ignore it in the YAML format in the config.

@yozachar
Copy link
Collaborator

 IGNORED_LANGUAGES: YAML "GitIgnore file" TOML

@Poisonlocket
Copy link
Author

 IGNORED_LANGUAGES: YAML "GitIgnore file" TOML

Ive already tried that, doesnt seem to work, verified it with the config

@Poisonlocket
Copy link
Author

image
image

@yozachar
Copy link
Collaborator

ignored_languages = set[str](igl.lower() for igl in wk_i.ignored_languages.strip().split())

Right, this needs to be improved.

@yozachar yozachar changed the title Ignoring the Gitignore file Ignore "language names" with spaces in-between Mar 31, 2024
@yozachar yozachar added bug Something isn't working good first issue Good for newcomers labels Mar 31, 2024
@Poisonlocket Poisonlocket reopened this Mar 31, 2024
@Poisonlocket
Copy link
Author

ignored_languages = set[str](igl.lower() for igl in wk_i.ignored_languages.strip().split())

Right, this needs to be improved.

I'd be more than happy to fix this

@yozachar
Copy link
Collaborator

yozachar commented Apr 1, 2024

PR is welcome.

@Poisonlocket
Copy link
Author

PR is welcome.

Its probably not possible to keep it the way but if i update it with comma separation its possible

@yozachar
Copy link
Collaborator

yozachar commented Apr 1, 2024

Coma separation will work, but you might not want to upset no idea how many of those ~7k users use the IGNORED_LANGUAGES flag.

image

@Poisonlocket
Copy link
Author

Coma separation will work, but you might not want to upset no idea how many of those ~7k users use the IGNORED_LANGUAGES flag.

image

Makes sense, will probably just take all the languages received from Wakatime and if I find it in the Ignored langs string I'll strip it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants