Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Dropdown as much as possible in Lookup #1020

Open
mvorisek opened this issue Mar 27, 2020 · 4 comments
Open

Reuse Dropdown as much as possible in Lookup #1020

mvorisek opened this issue Mar 27, 2020 · 4 comments

Comments

@mvorisek
Copy link
Member

This is a feature request to reuse Dropdown as much as possible in Lookup.

I understand that in the future that Lookup can be more than simple dropdown so I propose not extending Dropdown directly but reusing the the Dropdown component as much as possible. Currently lot of the base code is shared which is hard to maintain.

@ibelar
Copy link
Contributor

ibelar commented Mar 27, 2020

Actually, DropDown and Lookup are both extending Input.
In fact Lookup should be an extension of DropDown. They use the same Fomantic-Ui dropdown module at their base but Lookup use the api configuration of the module to perform server query.

@mvorisek
Copy link
Member Author

mvorisek commented Mar 27, 2020

In fact Lookup should be an extension of DropDown.

I am 100% ok with that. I proposed to wrap it as in the feature Lookup (at least from its name) can be much richer UI element like element with preview of the linked/lookuped value etc.

@romaninsh
Copy link
Member

we might have some functionality duplication - similarly to Modal and jsModal - there are some differences and possible that certain things will be discontinued and removed later on. Refactoring is not a huge priority and probably should wait until we've done with atk4/data#375

@mvorisek
Copy link
Member Author

also reuse it in Multiline, prerender it /wo value for vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants