-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse Dropdown as much as possible in Lookup #1020
Comments
Actually, DropDown and Lookup are both extending Input. |
I am 100% ok with that. I proposed to wrap it as in the feature |
we might have some functionality duplication - similarly to Modal and jsModal - there are some differences and possible that certain things will be discontinued and removed later on. Refactoring is not a huge priority and probably should wait until we've done with atk4/data#375 |
also reuse it in Multiline, prerender it /wo value for vue |
This is a feature request to reuse
Dropdown
as much as possible inLookup
.I understand that in the future that
Lookup
can be more than simple dropdown so I propose not extendingDropdown
directly but reusing the theDropdown
component as much as possible. Currently lot of the base code is shared which is hard to maintain.The text was updated successfully, but these errors were encountered: