Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardDeck won't reload after completed UserAction with applies_to_single_record #1910

Closed
mkrecek234 opened this issue Oct 19, 2022 · 4 comments · Fixed by #2012
Closed

CardDeck won't reload after completed UserAction with applies_to_single_record #1910

mkrecek234 opened this issue Oct 19, 2022 · 4 comments · Fixed by #2012

Comments

@mkrecek234
Copy link
Contributor

  • You have a model with a UserAction that modifies, say the name, and has 'appliesTo' => \Atk4\Data\Model\UserAction::APPLIES_TO_SINGLE_RECORD

  • If you run that UserAction, the CardDeck should reload to reflect the changes in that record. In Crud, it works. Though, in CardDeck it won't reload the CardDeck.

Interestingly, after adding a new record, the CardDeck now updates, this did not work before.

@mvorisek
Copy link
Member

Please always post a demo link and exact steps to reproduce like you did in #1862 for example.

If such demos do not exist, you can still post a demo link with a diff of the changes needed to reproduce.

If no related demo exists, please post here a few lines of codes that can run on pure atk4/ui install, models used from atk4/ui can be present. I can then run such code and fix quickly. Otherwise I have to code such repro cases which costs time.

@mvorisek
Copy link
Member

isn't this #1848 duplicate?

it is a feature, it was never supported, but of course the behaviour should be unified/implemented

@mkrecek234
Copy link
Contributor Author

You're right, did not see you added also the missing reload cases for edit/deletes. Closing this as duplicate of #1848.

@mvorisek mvorisek removed the bug 🪲 label Jan 7, 2023
@mvorisek mvorisek removed their assignment Jan 7, 2023
@mkrecek234
Copy link
Contributor Author

@mvorisek Please check branch https://github.com/atk4/ui/tree/bug_card_deck for repro code. If you watch closely when deleting a record, you will see the first card gets a reload sign upon delete of any other card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants