Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRUD style changed since Fomantic-UI 2.9.0 #1901

Open
mkrecek234 opened this issue Oct 13, 2022 · 1 comment · May be fixed by #1956
Open

CRUD style changed since Fomantic-UI 2.9.0 #1901

mkrecek234 opened this issue Oct 13, 2022 · 1 comment · May be fixed by #1956
Labels
bug 🪲 CSS

Comments

@mkrecek234
Copy link
Contributor

Cruds now have a separator line between menu bar and the grid table - is this intentional? I think it is a waste of space:

image
@mvorisek
Copy link
Member

good UX catch, using too much real estate for nothing is of course bad, marking as a bug

I confirm this was not present with 2.8.8, hower the new FUI behaviour seems correct.

The problem is in

ui/template/grid.html

Line 5 in c7e1960

<div class="ui vertical segment" id="{$_id}">
vertical segment present introduced in #528

probably introduced by a mistake, the PR claims to add a container for customization only

mkrecek234 added a commit that referenced this issue Dec 23, 2022
@mkrecek234
Fix #1901 Remove Grid vertical line
dc51332
@mkrecek234 mkrecek234 linked a pull request Dec 23, 2022 that will close this issue
Draft
@mvorisek mvorisek changed the title Changed style since Fomantic-UI 2.9.0 CRUD style changed since Fomantic-UI 2.9.0 Jan 7, 2023
@mvorisek mvorisek added the CSS label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra vertical line from Grid atk4/ui
2 participants
@mvorisek @mkrecek234