Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally build web-extension*.lisp #2917

Closed
Ambrevar opened this issue Apr 20, 2023 · 1 comment · Fixed by #3270
Closed

Optionally build web-extension*.lisp #2917

Ambrevar opened this issue Apr 20, 2023 · 1 comment · Fixed by #3270
Labels

Comments

@Ambrevar
Copy link
Member

Currently the web-extension*.lisp files are built into the default binary, while the library support is not built by default.

This is inconsistent and GTK should not depend so strongly on web-extensions.

I propose to add a feature macro to toggle the web-extension dependency in gtk.lisp.

Maybe better: Leverage more of CLOS and have a gtk-with-web-extension renderer.

@aartaka
Copy link
Contributor

aartaka commented Apr 20, 2023

This is inconsistent and GTK should not depend so strongly on web-extensions.

For sure, yes. I think that we should add as much on-signal-* methods and thus decouple Nyxt side from the FFI port. on-signal-* methods are part of our FFI anyway (maybe move them to foreign-interface.lisp?)

I propose to add a feature macro to toggle the web-extension dependency in gtk.lisp.

That'd work too, but I'd rather decouple it in a different way :)

Maybe better: Leverage more of CLOS and have a gtk-with-web-extension renderer.

That's an option too, yes.

@aartaka aartaka mentioned this issue Dec 4, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants