Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer percentiles are not persisted like the base metric #135

Open
tiedotguy opened this issue Sep 17, 2017 · 1 comment
Open

Timer percentiles are not persisted like the base metric #135

tiedotguy opened this issue Sep 17, 2017 · 1 comment
Labels

Comments

@tiedotguy
Copy link
Collaborator

If no timer metrics are received in a flush interval for a timer metric persisted from the previous flush interval, the aggregator never calculates new percentiles (even as 0).

Depending on the behavior of the backend, this can cause invalid values where metric.upper_pct > metric.upper.

https://github.com/atlassian/gostatsd/blob/master/pkg/statsd/aggregator.go#L158 should probably create dummy values.

@tiedotguy tiedotguy added the bug label Sep 17, 2017
@tiedotguy
Copy link
Collaborator Author

Similar behavior when numInThreshold=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant