Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Validating web hook for synchronous validation #289

Open
ash2k opened this issue May 28, 2018 · 2 comments
Open

Validating web hook for synchronous validation #289

ash2k opened this issue May 28, 2018 · 2 comments
Labels
feature

Comments

@ash2k
Copy link
Contributor

ash2k commented May 28, 2018

Expose a validating admission hook endpoint to enable synchronous Bundle validation.
@ash2k ash2k added the feature label May 28, 2018
@ash2k ash2k changed the title Validating wek hook for synchronous validation Validating web hook for synchronous validation May 28, 2018
@ash2k
Copy link
Contributor Author

ash2k commented Sep 19, 2018

Perhaps it should be a different binary in the same docker image deployed as a separate Deployment to avoid coupling - if smith is crashing/etc it should not influence the webhook.

@ash2k
Copy link
Contributor Author

ash2k commented Jan 9, 2019

A validation step: prohibit Bundles with resources with annotation DeletionTimestampAnnotation . See #396 (comment)

@ash2k ash2k mentioned this issue Jan 9, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ash2k