Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pathlib support in FileSet and FileInfo #379

Open
gerritholl opened this issue Oct 16, 2020 · 0 comments
Open

Add Pathlib support in FileSet and FileInfo #379

gerritholl opened this issue Oct 16, 2020 · 0 comments
Labels
API changes Affect user’s comprehension discussion Conversation about feature ideas feature Brand new functionality

Comments

@gerritholl
Copy link
Contributor

It would be nice if Pathlib.Path was fully supported in FileSet and FileInfo. I haven't tested how (in)complete it currently works to add Path instances rather than strings representings paths, but at least no Pathlib is used at all in test_fileset.py, and although creating a FileInfo instances where path is a pathlib.Path instance, it currently (and with #378) compares unequal to another FileInfo instance where a string represents the same path, which I don't think is desirable.
@gerritholl gerritholl added API changes Affect user’s comprehension discussion Conversation about feature ideas feature Brand new functionality labels Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API changes Affect user’s comprehension discussion Conversation about feature ideas feature Brand new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gerritholl