Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get correct cwd when treeview is the previousActiveItem #102

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

tom-power
Copy link
Contributor

Identify the Bug

#101

Description of the Change

  • use selectedPath in getInitialCwd when getPath doesn't return anything, which is the case for tree view items

Verification Process

Added tests, used for a while

Release Notes

  • path of terminal opened with atomic-terminal:open now matches the selected project

-->

@UziTech
Copy link
Member

UziTech commented Oct 29, 2022

If you want to get the tests passing I can merge this but I don't know if it is worth it since Atom is sunsetting soon

@tom-power tom-power force-pushed the treeviewCwd branch 2 times, most recently from 039fb97 to c9a2ede Compare November 4, 2022 08:26
@tom-power
Copy link
Contributor Author

sorry, can't think of another way to change these, and yes sunset but it still works :)

@UziTech UziTech merged commit e462b00 into atom-community:master Nov 4, 2022
@UziTech
Copy link
Member

UziTech commented Nov 4, 2022

Thanks for fixing this. 💯

@tom-power
Copy link
Contributor Author

awesome thank you 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants