Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Build script broken with ESLint 3.x? #44

Closed
morkro opened this issue Jul 7, 2016 · 5 comments
Closed

Build script broken with ESLint 3.x? #44

morkro opened this issue Jul 7, 2016 · 5 comments

Comments

@morkro
Copy link

morkro commented Jul 7, 2016

Hello,

I am using the build-package.sh and it has always worked great for my project, but since I've updated to ESLint 3.x my build is broken.

The problem seems to be that the script uses the APM versions, which is Node 0.10.40, but ESLint 3.x requires Node >=4.

Is there a way to fix or work around this?

@thomasjo
Copy link
Contributor

thomasjo commented Jul 7, 2016

This was fixed in #43. Try restarting your builds ♻️

@thomasjo thomasjo closed this as completed Jul 7, 2016
@morkro
Copy link
Author

morkro commented Jul 7, 2016

Awesome, thanks!

@morkro
Copy link
Author

morkro commented Jul 7, 2016

Sorry to be noisy, but the issue remains. :/

@thomasjo
Copy link
Contributor

thomasjo commented Jul 7, 2016

Oh, that specific issue won't be fixed by anything we can do here. If an npm package is listed as a dependency it will be installed using apm and not npm, and apm uses Node v0.10.40 still.

If you want to use eslint v3 and above, then for the time being you'll have to deal with linting on your own. That means removing it as a dependency in your package.json, installing it into e.g. a script folder along with a custom lint script or some such.

On a side note, this shouldn't even work locally? What you are seeing is not specific to running stuff on Travis CI.

Furthermore, this will be fixed when atom/atom#11897 🚢s.

@morkro
Copy link
Author

morkro commented Jul 7, 2016

Ah okay, got it.

Locally I have always been linting with npm scripts like eslint lib && eslint spec. I didn't know there is an apm linting command available?

Is there a rough estimate when atom/atom#11897 will be merged? Either I just wait, or go back to ESLint 2.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants