Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Comment threads on same line appear in the wrong order #1944

Closed
kuychaco opened this issue Feb 5, 2019 · 2 comments
Closed

Comment threads on same line appear in the wrong order #1944

kuychaco opened this issue Feb 5, 2019 · 2 comments

Comments

@kuychaco
Copy link
Contributor

kuychaco commented Feb 5, 2019 •
edited
Loading

multiple_threads_by_kuychaco_ _pull_request__5_ _kuychaco_test-repo_and_pr__kuychaco_test-repo_5_ _multiple_threads_ ___github_github

Note: the comments within the thread seem to be ordered correctly. But the threads themselves are not.

Test PR: https://github.com/kuychaco/test-repo/pull/5/files
@kuychaco kuychaco mentioned this issue Feb 5, 2019
Closed
18 tasks
@smashwilson
Copy link
Contributor

We've changed to using the PullRequest#reviewThreads connection in GraphQL in #1995, which might fix this for us by ✨ magic ✨. But we should at least verify 😄

@kuychaco
Copy link
Contributor Author

Verified this is fixed in v0.28.0 ✨✨✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smashwilson @kuychaco