This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Extract common "isCheckedOutPullRequest" function #2045

Open

smashwilson opened this issue Apr 8, 2019 · 0 comments

Labels

code-cleanup 🔧

Contributor

smashwilson commented Apr 8, 2019

From #1995 (comment):

Yeah the code looks pretty similar, I'd be 👍 to extract it. That said, I'm okay shipping as is, especially since we're short on time before the Atom release. If we need this logic a third time in the future I'd say we definitely want to extract it, but for now I'm fine either way.

The common code is in lib/controllers/comment-decorations-controller.js and lib/controllers/pr-checkout-controller.js.

The text was updated successfully, but these errors were encountered:

smashwilson added the code-cleanup 🔧 label

smashwilson mentioned this issue

Reviews dock item #1995

Merged

46 tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.