Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Git changes not showing up in Git tab depending on how I add directories to tree view #2374

Closed
1 task done
mikkovedru opened this issue Dec 17, 2019 · 1 comment
Closed
1 task done

Comments

@mikkovedru
Copy link

Prerequisites

Description

I have a project that uses a bunch of other packages. I am making changes to the source code of both the main project and the packages (each being its own git repo). The directory structure is:

.
├── Project
├── Project Packages
│  ├── Package1
│  ├── Package2
│  ├── Package3

The problem is that if I add Project Packages directory to the Tree View, my git changes made in the packages are not shown. They are shown only if I add each package separately.

Steps to Reproduce

  1. Create the directory structure like described above. Each directory should be a separate git repo.
  2. Make changes to packages and make sure that git sees them.
  3. Add Project Packages directory to Tree View.
  4. See that none of the changes to the packages are shown in Atom's git tab.
  5. Remove the Project Packages directory (Right click on directory -> "Remove Project Folder").
  6. Add packages directories separately.
  7. See that all the changes are now visible in the Git tab.

Expected and Actual behavior:
I expect for the logic to work as "for the opened and active file, go each directory up until you encounter the git file and show its info", but clearly that's not the case. The logic seems to be "go directly to the top directory and if it doesn't have any git info, assume that it doesn't exist".

I think that the behavior I described is better, more logical and should be implemented (or fixed, if it's a bug).

Reproduces how often:
100%

Versions

OS
Linux Mint 19.2 Cinnamon (4.2.4)
Kernel: 5.0.0-36-generic

atom --version
Atom : 1.41.0
Electron: 4.2.7
Chrome : 69.0.3497.128
Node : 10.11.0

apm --version
apm 2.4.3
npm 6.2.0
node 10.2.1 x64
atom 1.41.0
python 3.6.4
git 2.17.1

@Arcanemagus Arcanemagus transferred this issue from atom/atom Dec 17, 2019
@Arcanemagus
Copy link

Thanks for taking the time to contribute!

We noticed that this is a duplicate of #1835. You may want to subscribe there for updates.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants