Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Use a persistent child process for git operations #643

Closed
smashwilson opened this issue Apr 4, 2017 · 1 comment · Fixed by #688
Closed

Use a persistent child process for git operations #643

smashwilson opened this issue Apr 4, 2017 · 1 comment · Fixed by #688
Assignees

Comments

@smashwilson
Copy link
Contributor

As a band-aid for #386 that's achievable by public launch, we could maintain a single, long-living child process à la the ones used byGitPromptServer and use IPC to trigger git operations in that thread instead. That way, our spawn calls at least wouldn't block the event loop for typing events 😡.

We could possibly disable it on Windows or Linux initially depending on whether or not we can ever reproduce it then.

/cc @nathansobo

@nathansobo
Copy link
Contributor

Great to see you take this up. Hate to be a buzzkill harping on this issue, but I'm just terrified of affecting typing performance negatively.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants