This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
fix: @each block end
#268
Closed
fix: @each block end
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thank you @jquense 👍 Would you be able to add a test so that future changes don't break your fix? |
|
Sure I can try! do they have to be in coffee script? I've never used that but probably can pick it up |
|
🙇
Sorry, yes looks like the current specs are CoffeeScript. |
|
getting coffescript to work here is a real barrier to contribution fyi...this is likely a 5 min task but i don't really have all the extra time to figure out and learn enough coffescript necessary to write this test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Fixes, syntax highlighting for
@eachstatements. Updated to match the other control flow/iteration patterns (seeif,else,for, etc)old:
new:
Alternate Designs
Benefits
Code will be highlighted more accurately. Specifically in nested language cases, such as CSS-in-js style colocation of scss styles in js
Possible Drawbacks
It could be the wrong fix?
Applicable Issues
Fixes #267