Pressing the space bar while inside any TextEditor scrolls the window down

[BinaryMuse]

Pressing the space bar with the focus inside any settings-view TextEditor (to insert a space character) scrolls the window.

[JSn1nj4]

What OS are you on, and what Atom version?

[BinaryMuse]

I'm on the latest master (1.9.0-dev-c4d4e0f), settings-view 0.235.1, OS X 10.11.4.

[lee-dohm]

I could reproduce this on the Install tab, but not the Packages tab using Atom v1.9.0-dev-c4d4e0f on Mac OS X 10.11.4.

[jerone]

Reproducible on every tab (Settings, Keybindings, Packages, Themes & Install) on Windows 7 with Atom 1.8.0-beta2 and 1.8.0-beta3.

[NFiorentini]

Reproduced on every tab using Atom v1.8.0-beta4 on Windows 10.0.10586 Build 10586.

[muendelezaji]

Any updates on this?
Still happening on Atom 1.8.0 release, OS X 10.11.5. All tabs - Settings, Keybindings, Packages, Themes & Install

[leshniak]

I made a workaround in my init.coffee, unfortunately works only partially (only on Settings panel or if you open all settings panels and then reopen settings tab). Maybe someone knows how to bind it better [link deprecated]

[leshniak]

Ok, new version of my workaround works good. Put it in the init.coffee and enjoy.

[claudiofantacci]

@leshniak 's workaround works smoothly. Thanks!

Looking forward for a mainstream bugfix as well.

[muendelezaji]

Works for me too. Thanks @leshniak

[leshniak]

I think it should be fixed on atom-text-editor level, but maybe I'm wrong, I don't know Atom and Electron too much.

Btw, I made newer version of my workaround, w/o jQuery, it works with every atom-text-editor[mini] component. Link to gist in my previous comment.

[claudiofantacci]

@leshniak I opened an issue about this problem on atom and it was closed with the "wrong repo" label and redirected here. Thus I assume it's the correct one.

[NFiorentini]

Thank you, @leshniak!

[jerone]

I did some testing and I can reproduce this issue from at least 13 Sep 2015 7b60bb5 (anything earlier gives errors for now).

[jerone]

Identified the problem by removing the textInput event (in the Dev Tools) attached on the TextEditorComponent.

[claudiofantacci]

Ok, then we might want to wait for a bugfix release and after that remove @leshniak workaround.

[ricefai]

Works for me, thanks

[bastilian]

Anyone working on this? Otherwise i would take a look at it.

[bastilian]

So, I've been looking into this, I believe the best way to address this would be to prevent this behaviour in the mini mode by using the setMini function of TextEditor and add an event listener that handles the spacebar event, simply ignoring it and stop it from bubbling up and cause the the default chrome behaviour and scroll.

BUT this may just be a workaround and not the root of the problem, as I have yet to find out why this behaviour is not occur in places like find-and-replace, where TextEditor is used in mini as well.

My two theories are that it doesn't do it because it is observing changes with a handler that prevents this already or it does occur, but halts and is not effective since the view the TextEditor is in is not scrollable.

When I have found out why this doesn't happen in find-or-replace, I would open a issue on atom/atom proposing the change and discuss it further there.

[DamnedScholar]

I have yet to find out why this behaviour is not occur in places like find-and-replace, where TextEditor is used in mini as well.

You've made it so that find-and-replace scrolls in order to test this?

[bastilian]

@DamnedScholar no, that should read "...this behaviour does not occur..." :) and that is what I still need to figure out.

[ShadowLNC]

Reproducible on 1.8.0 release, Win10 64-bit, all tabs (except Updates which has no text input).

In regards to find-and-replace, it usually either focuses the file TextEditor or one of the TextEditors (mini) inside the find-and-replace dialog, but on the occasions that I get all cursors to disappear, spacebar will refocus the file TextEditor and insert the space there (suggesting the file TextEditor was actually focused without a cursor).

Clicking on empty space in the tab bar will also unfocus the cursor, but the spacebar then has no effect (suggesting the file TextEditor is properly unfocused this time).

Spacebar in tile-view also scrolls, though that may be intended behaviour (and it's not this package, but it's worth noting the behaviour).

[bastilian]

I had to modify the style of the elements a bit to make it happen, but as I suspected this behaviour happens not only in settings-view:

I'll investigate this more what triggers the behaviour, how it can be fixed and open an issue on atom/atom. I'm not really happy with the solution I proposed above, since I have the feeling there is a tiny bit more behind it.

[andrewstart]

For your coming issue on atom: I've been seeing this problem in the custom editors that I am working on. When any atom-text-editor (mini or not) is contained within a scrollable section of the page, then spacebar causes that section to scroll.

[philxchen]

Reproduced.

Windows 10 build 14366 ~ 14388
Atom 1.9.0-beta0

However, only the first Space triggers the problem, while following ones work properly.

[danielbayley]

😞
I'm also getting this on:

Atom 1.8.0
OS X 10.11.6
settings-view 0.235.1

[ghost]

Also happens on ubuntu 16.04

Atom    : 1.8.0
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

[andyrichardson]

Just encountered this on Fedora 24

[damieng]

I don't think we need any more messages about it happening. It happens everywhere on all systems.

[nathansobo]

This just came to my attention and is a really bad regression. My apologies to everyone affected. A fix will be out with the next release (shortly).

[sharifzadesina]

Still exists.

ubuntu 16.04
atom 1.8

[brainscript]

Same here. 😞

eOS Freya (Ubuntu 14.04)
Atom 1.8.0

[jerone]

I can confirm this being fixed for Windows with Atom 1.9.0-beta2.

[mnquintana]

This has been fixed for the next release of Atom, which isn't out yet. If you want to get the fix sooner, you might be interested in the Beta channel.

[Kaukov]

I can confirm this has been fixed in 1.9.0

Tested on Windows 10 Pro x64 & ElementaryOS Loki Beta 2 (Ubuntu 16.04)