Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Selected item not visible when changing selection via arrow up key #1245

Closed
1 task done
lloiser opened this issue Apr 23, 2018 · 6 comments · Fixed by atom/one-light-ui#132
Closed
1 task done

Selected item not visible when changing selection via arrow up key #1245

lloiser opened this issue Apr 23, 2018 · 6 comments · Fixed by atom/one-light-ui#132
Labels

Comments

@lloiser
Copy link

lloiser commented Apr 23, 2018

Prerequisites

Description

The selected item is not shown in the tree view if you change the selection using the arrow up key.

Steps to Reproduce

tree

Expected behavior:
The selected item should always be visible.

Actual behavior:
The selected item is not visible.

Reproduces how often:
100%

Versions

$ atom --version
Atom    : 1.26.0
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0
$ apm ls
...
├── one-dark-ui@1.11.0
├── one-dark-syntax@1.8.2
├── tree-view@0.221.3
...
@rsese
Copy link

rsese commented Apr 23, 2018

Thanks for contributing!

We noticed that this looks like a duplicate of #834 so you can subscribe there if you'd like. I also quickly tried the suggestion in #834 (comment) and that seems to work.


Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

@rsese rsese closed this as completed Apr 23, 2018
@lloiser
Copy link
Author

lloiser commented Apr 24, 2018

This is actually not a duplicate. In #834 they talk about the preview, which I don't care about.
My problem is that the selected item is not visible if I change the selection via the arrow up key. Checkout the gif again :)

@lloiser
Copy link
Author

lloiser commented Apr 24, 2018

hm.. I cannot reopen this issue. Can someone pls do it for me 😁

@Ben3eeE Ben3eeE added the ui label Apr 24, 2018
@Ben3eeE Ben3eeE reopened this Apr 24, 2018
@Ben3eeE
Copy link
Contributor

Ben3eeE commented Apr 24, 2018

I tested this on a recent master which includes the atom/one-dark-ui#252 fix and I can reproduce this issue for folders in the tree-view but not for files.

/cc: @simurai This looks like another problem with sticky project folders like atom/one-dark-ui#252 fixed

@simurai
Copy link
Contributor

simurai commented Apr 26, 2018

@Ben3eeE I can reproduce this issue for folders in the tree-view but not for files

👍 Should be fixed with atom/one-light-ui#132.

@rsese
Copy link

rsese commented Apr 26, 2018

This is actually not a duplicate. In #834 they talk about the preview, which I don't care about.
My problem is that the selected item is not visible if I change the selection via the arrow up key. Checkout the gif again :)

Ahhh sorry about that @lloiser 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants