Various PR comment improvements, thanks @Polleps

Author: joepio

data-browser/src/components/NewInstanceButton/Base.tsx

@@ -44,7 +44,7 @@ export function Base({
       subtle={subtle}
       title={agent ? `Create a new ${title}` : 'No User set - sign in first'}
     >
-      {icon ? <FaPlus /> : label || title}
+      {icon ? <FaPlus /> : label ?? title}
       {children}
     </Button>
   );

data-browser/src/components/Parent.tsx

@@ -65,7 +65,6 @@ function NestedParent({ subject, depth }: NestedParentProps): JSX.Element {
   const [parent] = useString(resource, properties.parent);
   const navigate = useNavigate();
   const [title] = useTitle(resource);
-  depth = depth + 1;
 
   // Prevent infinite recursion, set a limit to parent breadcrumbs
   if (depth > 5) {
@@ -79,7 +78,7 @@ function NestedParent({ subject, depth }: NestedParentProps): JSX.Element {
 
   return (
     <>
-      {parent && <NestedParent subject={parent} depth={depth} />}
+      {parent && <NestedParent subject={parent} depth={depth + 1} />}
       <Breadcrumb href={subject} onClick={handleClick}>
         {title}
       </Breadcrumb>

data-browser/src/components/forms/hooks/useSaveResource.ts

@@ -29,14 +29,14 @@ export const useSaveResource = (
       setErr(null);
 
       try {
-        if (resource.new) {
-          store.notifyResourceManuallyCreated(resource);
-        }
-
         await resource.save(store);
         setSaving(false);
         onSaveSucces();
         toast.success('Resource saved');
+
+        if (resource.new) {
+          store.notifyResourceManuallyCreated(resource);
+        }
       } catch (err) {
         setErr(err);
         setSaving(false);

data-browser/src/views/ErrorPage.tsx

@@ -91,7 +91,7 @@ export class ErrorBoundary extends React.Component<
       return (
         <CrashPage
           error={this.state.error}
-          clearError={() => this.setState(() => ({ error: undefined }))}
+          clearError={() => this.setState({ error: undefined })}
           info={{} as React.ErrorInfo}
         />
       );

data-browser/src/views/ImporterPage.tsx

@@ -9,7 +9,6 @@ import {
   InputWrapper,
   TextAreaStyled,
 } from '../components/forms/InputStyles.jsx';
-import Parent from '../components/Parent';
 import ResourceCard from './Card/ResourceCard';
 import { ErrorLook } from './ResourceInline.jsx';
 import { ResourcePageProps } from './ResourcePage';

data-browser/src/views/ResourcePageDefault.tsx

@@ -4,7 +4,6 @@ import AllProps from '../components/AllProps';
 import { ClassDetail } from '../components/ClassDetail';
 import { ContainerNarrow } from '../components/Containers';
 import { ValueForm } from '../components/forms/ValueForm';
-import Parent from '../components/Parent';
 import { ResourcePageProps } from './ResourcePage';
 import { CommitDetail } from '../components/CommitDetail';
 import { Details } from '../components/Detail';

package.json

@@ -47,9 +47,9 @@
       "lib",
       "react",
       "data-browser"
-    ],
-    "packageManager": "pnpm@7.11.0"
+    ]
   },
+  "packageManager": "pnpm@7.11.0",
   "dependencies": {
     "eslint-plugin-import": "^2.26.0"
   }

react/src/hooks.ts

@@ -367,7 +367,7 @@ const titleHookOpts: useValueOptions = {
  */
 export function useTitle(
   resource: Resource,
-  truncateLength?: number,
+  truncateLength = 40,
 ): [string, (string: string) => Promise<void>] {
   const [name, setName] = useString(
     resource,
@@ -385,9 +385,6 @@ export function useTitle(
     titleHookOpts,
   );
 
-  // TODO: truncate non urls
-  truncateLength = truncateLength ? truncateLength : 40;
-
   if (resource.loading) {
     return ['...', setName];
   }