Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ensureBranch behavior when sync false #214

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Conversation

ddgenome
Copy link
Contributor

@ddgenome ddgenome commented Feb 1, 2021

Do not consider remote branches at all in ensureBranch when sync is
false. Update tests. Ensure remote.origin.fetch configuration maps all
branches, not just the one cloned.

Set clone options in slow git operation tests to clone specific branch
with set depth so as to better mimic how repos are cloned in skill
executions.

Closes #210

@ddgenome ddgenome requested a review from cdupuis February 1, 2021 19:38
@atomist atomist bot added auto-branch-delete:on-close Delete branch when pull request gets closed auto-merge-method:merge Auto-merge with merge commit auto-merge:on-approve Auto-merge on review approvals labels Feb 1, 2021
@ddgenome ddgenome added the changelog:changed Add this issue or pull request to changed changelog section label Feb 1, 2021
Do not consider remote branches at all in ensureBranch when sync is
false. Update tests. Ensure remote.origin.fetch configuration maps all
branches, not just the one cloned.

Set clone options in slow git operation tests to clone specific branch
with set depth so as to better mimic how repos are cloned in skill
executions.

Closes #210
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atomist atomist bot merged commit d64ca8e into main Feb 1, 2021
@atomist
Copy link
Contributor

atomist bot commented Feb 1, 2021

Pull request auto merged:

  • 1 approved review by @cdupuis
  • 9 successful checks

@atomist atomist bot deleted the ensure-branch-210 branch February 1, 2021 21:19
atomist bot pushed a commit that referenced this pull request Feb 1, 2021
-   #214 to changed

[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-branch-delete:on-close Delete branch when pull request gets closed auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit changelog:changed Add this issue or pull request to changed changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error committing changes back into repository
2 participants