Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/gov): min amount per deposit #13

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

adam-hanna
Copy link
Contributor

Please go the the Preview tab and select the appropriate sub-template:

  • Production code - for types fix, feat, and refactor.
  • Docs - for documentation changes.
  • Others - for changes that do not affect production code.

@adam-hanna adam-hanna changed the title Attempt #2 Min amount per deposit - attempt #2 Sep 12, 2024
@adam-hanna
Copy link
Contributor Author

Ok, the problem with my other PR, is that I tried to bring in every file that was changed by that PR.

Now that I have a better understanding of the cosmos-sdk code base, I know that some of the changes aren't relevant for what we're trying to do now.

This is a much smaller PR :)

Copy link
Collaborator

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! It looks pretty good now.
Just one tiny thing, it seems that you (accidentaly?) run gofumpt on the generated proto files. You can see that by re-generate them using make proto-gen, the new files are differents whereas they shouldn't. Just fix that and we should be good to merge.

@adam-hanna
Copy link
Contributor Author

adam-hanna commented Sep 16, 2024

Nice job! It looks pretty good now. Just one tiny thing, it seems that you (accidentaly?) run gofumpt on the generated proto files. You can see that by re-generate them using make proto-gen, the new files are differents whereas they shouldn't. Just fix that and we should be good to merge.

Thanks!

Ok, I re-generated them. It seems like there are still some minor formatting differences? Could be because I'm on a diff version of buf?

$ buf --version
1.32.1

@tbruyelle
Copy link
Collaborator

Ok, I re-generated them. It seems like there are still some minor formatting differences? Could be because I'm on a diff version of buf?

I don't see any differences, I pulled your changes and ran make proto-gen, no changes so all good.

@tbruyelle tbruyelle changed the title Min amount per deposit - attempt #2 feat(x/gov): min amount per deposit Sep 17, 2024
@tbruyelle tbruyelle merged commit 7a102b4 into main Sep 17, 2024
14 checks passed
@tbruyelle tbruyelle deleted the adam-hanna/gov/min-amount-per-deposit-v2 branch September 17, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants