Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubs and atoum extensions #3

Open
agallou opened this issue Dec 8, 2015 · 4 comments
Open

stubs and atoum extensions #3

agallou opened this issue Dec 8, 2015 · 4 comments

Comments

@agallou
Copy link
Member

agallou commented Dec 8, 2015

Some extensions add new asserters.

Do you know how we could also add autocomplete on this asserters ?

(adding another atoum class causes problems for the autocompletion).

(
plus, if we found there could be packaging questions, where do we put the stub ?

  • atoum/stub : won't have implementation problems, but, autocomplete will show unavailable methods
  • atoum/blackfire-extension
  • atoum/blackfire-extension-stubs
    )
    (in the last 2, I don't know how we could do this).
@jubianchi
Copy link
Member

@agallou I would say that each extension should expose its own stubs. I'll try to build one for an extension to see how we could make this.

@agallou
Copy link
Member Author

agallou commented Dec 28, 2015

Proposal :

  • stubs are defined in the extension (file1 and file2)
  • in the stubs repository, we use each extension trait (file3)

Example : https://gist.github.com/agallou/1bde12b1f3bea9894b0a

This means we have to maintain a list of extensions in the asserters.php file of the stubs projets (it won't cause any problem if the trait does not exists).
I'm not a fan of this but haven't found another way to do this.

@jubianchi jubianchi changed the title subs and atoum extensions stubs and atoum extensions Jan 6, 2016
@Grummfy
Copy link
Member

Grummfy commented Apr 15, 2016

+1 for me

@Grummfy
Copy link
Member

Grummfy commented Oct 2, 2017

well let's see atoum/atoum#753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants