Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Please avoid node dependency to "natives" module #24

Closed
bpasero opened this issue Apr 10, 2018 · 2 comments
Closed

Please avoid node dependency to "natives" module #24

bpasero opened this issue Apr 10, 2018 · 2 comments

Comments

@bpasero
Copy link

bpasero commented Apr 10, 2018

Hi,

I am a developer on VSCode and wanted to reach out to inform you that this extension is either using or having a dependency to a node module "natives" that will soon no longer be supported in VSCode once we updated to node.js 8.x (as part of our Electron 2.0 update which is planned for the near term).

The full graph is:

└─┬ webshot@0.18.0
  └─┬ graceful-fs@3.0.11
    └── natives@1.1.2 

It would be great if this dependency could be avoided by either not depending on it anymore or updating the dependencies to newer versions so that this module is no longer pulled in.

As soon as any code in your extension (including node_modules) calls require("natives") we will throw an exception to prevent this module from getting loaded.

More details in microsoft/vscode#47569

Thanks!
Ben
VSCode Team

@attilabuti
Copy link
Owner

Hello @bpasero

Thanks for the warning!
The issue is fixed on 1.2.1.

@bpasero
Copy link
Author

bpasero commented Apr 16, 2018

@attilabuti thanks 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants