Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split 'allowCrossDomain' into 2 settings! #384

Open
charlesr1971 opened this issue Jan 18, 2019 · 1 comment
Open

Split 'allowCrossDomain' into 2 settings! #384

charlesr1971 opened this issue Jan 18, 2019 · 1 comment

Comments

@charlesr1971
Copy link

Adam. I really love Taffy. It is a great REST framework. There is just one small change, that comes to mind.

In the framework config:

allowCrossDomain: boolean | string

Should be just set to a boolean data type. The string option should be removed

Then you could have another config key called:

crossDomains: string

This value would replace the string data type of 'allowCrossDomain'.

The point behind this, is that some developers might want to turn off the 3 headers that 'allowCrossDomain' automatically creates, but, at the same time, they might want to add their own CORS domain values.

Anyway, just a thought?

@atuttle
Copy link
Owner

atuttle commented Oct 1, 2020

Wouldn't having some hostnames allowed imply that cross-domain access should be enabled? I can understand the request from a data-type perspective (a variable that's sometimes a bool and sometimes a string can be confusing) but other than that, doesn't combining it save us a configuration setting that would be implied otherwise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants