Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRID to geometry types on write #330

Closed
sirex opened this issue Dec 8, 2022 · 0 comments · Fixed by #354
Closed

Add SRID to geometry types on write #330

sirex opened this issue Dec 8, 2022 · 0 comments · Fixed by #354
Labels
bug Something isn't working

Comments

@sirex
Copy link
Collaborator

sirex commented Dec 8, 2022

Currently, SRID is not specified on writes, for example if following data are received from client:

POINT(-44.3 60.1)

it is passed to database as is. But after fixing a bug with geometry type arguments:

ccc7ab1#diff-ef698dfa7530dce56bc8139a272f35940c59a01449c3c23bfe5fbb538effe5cc

Now database geometry types are created with shape and srid, which gives following errors if SRID is not specified:

Geometry SRID (0) does not match column SRID (3346)

So in order to fix that, client now must specify SRID:

SRID=4326;POINT(-44.3 60.1)

But this breaks backward compatibility, so clients should still be able to write data without SRID, and SRID should be added automatically using value specified in manifest file.

'coordinates': 'SRID=3346;POINT(582710 6061887)',

API should accept both cases, with SRID and without.

@sirex sirex added the bug Something isn't working label Jan 26, 2023
@adp-atea adp-atea moved this to In Progress in Portalo plėtra Feb 2, 2023
@adp-atea adp-atea linked a pull request Feb 2, 2023 that will close this issue
@adp-atea adp-atea moved this from In Progress to Review in Portalo plėtra Feb 2, 2023
@sirex sirex moved this from Review to In Progress in Portalo plėtra Mar 2, 2023
@sirex sirex moved this from In Progress to Todo in Portalo plėtra Mar 2, 2023
@adp-atea adp-atea moved this from Todo to In Progress in Portalo plėtra Mar 3, 2023
@adp-atea adp-atea moved this from In Progress to Review in Portalo plėtra Mar 3, 2023
@sirex sirex moved this from Review to Todo in Portalo plėtra Mar 8, 2023
@adp-atea adp-atea moved this from Todo to In Progress in Portalo plėtra Mar 9, 2023
@adp-atea adp-atea moved this from In Progress to Review in Portalo plėtra Mar 9, 2023
@sirex sirex moved this from Review to Todo in Portalo plėtra Mar 13, 2023
@adp-atea adp-atea moved this from Todo to In Progress in Portalo plėtra Mar 15, 2023
@adp-atea adp-atea moved this from In Progress to Review in Portalo plėtra Mar 15, 2023
@sirex sirex moved this from Review to Done in Portalo plėtra Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant