Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frames.js - crc skip/check at wrong offset #7

Open
showstopper opened this issue Dec 24, 2011 · 2 comments
Open

frames.js - crc skip/check at wrong offset #7

showstopper opened this issue Dec 24, 2011 · 2 comments

Comments

@showstopper
Copy link

Refering to https://github.com/ofmlabs/jsmad/blob/master/src/frame.js#L111

Specs says that the 16-bit crc comes after the frame header. Therefore the skip should be located at https://github.com/ofmlabs/jsmad/blob/master/src/frame.js#L172.

@nddrylliog
Copy link
Contributor

So... test case + patch? :)

As you can see, jsmad (possibly libmad too) skips the crc check anyway, and it's skipped somewhere so it possibly doesn't corrupt decoding that much.

@showstopper
Copy link
Author

@nddrylliog Actually, if I understood this correctly, the rest of the header decoding is completely flawed if crc-protection is on. (Correct me if I'm wrong). I'll add test-patch later this evening (currently busy with exchanging presents and stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants